Warrior kings - Vanilla to now.

[Tib]

What were the alliance and horde warrior races of choice in each expansion?

Alliance

Vanilla

Tank -
DPS -
PvP -

Burning Crusade

Tank -
DPS -
PvP -

Wrath of the Lich King

Tank -
DPS -
PvP -

Catacalysm

Tank -
DPS -
PvP -

Horde

Vanilla

Tank -
DPS -
PvP -

Burning Crusade

Tank -
DPS -
PvP -

Wrath of the Lich King

Tank -
DPS -
PvP -

Catacalysm

Tank -
DPS -
PvP -

[Katzazi]

Horde: Tank -> Tauren, DPS/PVP -> Orc I would assume.

Bloodelf were impossible before Cata, Undead special can be more or less covered by berserker and Troll special only gives haste which gives a just a little bit more rage.

[klor]

This is and has been all opinionated. Personally I would say orc for all three spots for all four sections of the game. Others may disagree.