At this point in the game it's unnecessary to gem anything else but stamina, save for one purple gem to cover the meta bonus. There's a large discussion about it here if you need the reasoning why. Hit and expertise are unnecessary because warrior threat is heavily dependent on your rotation and spec moreso than your gear. What I mean is, if your threat is bad, it's not going to get better by adding offensive stats. Additionally, you can glyph taunt for fights that need taunts to land (Fester, LDW, Saurfang, Lich King). HP and Armor are your biggest priorities, that will make you the healers' wet dream.
Originally Posted by CARAMON1
For the OP- change your cloak enchant to armor, your weapon enchant to either blood draining or mongoose, and your chest enchant to 275 hp. It's debatable but you could change your glove enchant to 240 armor, but it's up to you. The Ony trinket is also garbage and there's only one fight in WoTLK where it is even remotely useful. Replace with either Black Heart from TOC 5 regular, Glyph of Indomitability from Triumph badges, or Juggernaut's Vitality from TOC 25. Otherwise I think your armory is in decent shape.
"There are no men like me...only me."