Iv had my tank for like 3 months and slowly built up his gear to a reasonable level. recently been having a few threat issues and wonder if someone could go over my talents and gear and suggest where am going wrong or what needs to be improved. Here is a link to my armory page
There are a few glaring details that you should probably change ASAP.
First off, never gem for Parry as the ratings are far less bang for your buck than Dodge.
Never gem for Crit/AP. AP should never be gemmed for in general (for DKs anyway), as Strength scales with +% and provides 2 AP per Str.
Put straight +24 stam gems in all blue slots, and either Dodge/Stam or Expertise/Stam in your red slots, and Hit/Stam in your yellow slots (until you are capped).
Put Armsman enchant on your gloves, you will appreciate the extra threat.
Your expertise is very very low for a DK tank. Your gear is pretty decent and I'm actually kind of surprised it is this low. Look especially for any + expertise pieces.
Try Blood Tanking. You will find that your threat generation will skyrocket on single/dual targets. If you are strictly a tank, you may want to keep your frost spec for AoE pulls, as some people have trouble AoE Blood Tanking.
For the most part your gear is good and your spec is decent. Re-gem and see how you do, and if you are still having problems, post your rotations and stuff. Maybe try the blood spec too
hey thanks again, i have no idea about macros etc gonna try that rotation though just changed some gems n the armsman enchant passed 30K unbuffed n dodge up to just about 25% parry 18ish expertise is still low hopefully some gear will drop next time i go on guild run to naxx