First off all, delete your macros.
You won't be a good tank unless your able to control every single skill of you character by yourself. Those macros won't help but are unflexible and needless rage-consuming.
There are - of course - some macros that actually help. For myself, I use the following:
Code:
#showtooltip Charge
/cast Charge
/cast Shield Bash
This macro will use charge if you are at least 8 metres away from your opponment - because charge only works at range, but will use shild bash if you're in melee range, because shild bash only works in melee range
. The nice part is, that this macro will break the casting of your enemy in both cases - either through the charge stun or the shild bash itself. It's very intuitive. I have this macro on the Space-key.
(btw: You can do - and I have - the same thing with intercept/shildbash or intercept/pummel etc)
Code:
#showtooltip Shieldslam
/cast Shieldslam
/Startattack
This is a very easy macro that helps you changing targets. You will find yourself spamming shildslam and with this macro you will atleast start autoattacing a new foe, even when shieldslam is not ready. This saves a rightclick, prevents clicking the wrong foe in the heat of the fight (and therefull changing target!).
Code:
#showtooltip Revenge
/cast Revenge
/cast !Heroic Strike
This macro is usefull if you have the revenge glyphe which allows a free hs after every revenge. Mind the "!" before heroic strikes: This prevents de-selecting HS while spamming - means you won't deacitvate hs if you use this macro twice in a row or if you use this macro and manually select hs at the same time.
Code:
#showtooltip Heroic Strike
/cast !Heroic Strike
Same thing as above: You can spam the hs key without deactivating hs every second click/keypress.
Code:
/run SetCVar('CameraDistanceMaxFactor','4');CameraZoomOut('255')
This is a very nice macros that allows your camera to be further away than you are used to. Very helpful at sartharion etc.
Bookmarks