[oorgle]

hey guys,

I'm the poster from the wow forums, viewtiful joe. I'd posted the question late last night and was pretty tired, so I didn't notice that I was on an alt.

Thanks for trying to help with my macro dilemma. I've tested the one you posted up here arbster, and it seems to work halfway, at least. If I start with fireguard/shield equipped, I end up with VB mainhand and FG offhand, shield in the bag slot. After that though it malfunctions, and simply leaves the VB in mainhand, swaps the bag slot and offhand (FG and shield).

The last line of the macro seems to be getting ignored in either case; I removed it entirely, and the same functionality was retained. I've built a separate macro to perform the other half of the operation, but my limited knowledge of scripting syntax is hurting me here. I'm sure there's a way to build them both into the same macro, but I can't quite figure it. Help!

Here's what I did for the 2nd half (switching from VB/FG to FG/Shld):

/script PickupInventoryItem(17)
/script PickupInventoryItem(16)
/script UseContainerItem(3,1)


Once again, i think it's just my limited knowledge of the syntax rules that's hurting me here. I tried a bunch of fiddling around with your macro, and eventually ended up back at the same place wondering why it doesn't work.

Is there any way to split it into two halves using an if/then/else sort of thing?
Something like:

If I have a shield equipped, then run something like the first half of abster's macro, else run something like the clunky macro I made for the 2nd operation.

[arbster]

Hi there - sorry my original suggestion didn't work - I wrote it off the top of my head without access to WoW. I think it fails due to trying to move the same item twice, which seems to confuse LUA sometimes. However, this version does work:

/run if IsEquippedItemType("Shields") then EquipItemByName("Vindicator's Brand",16) PickupContainerItem(4,1) PickupInventoryItem(17) else EquipItemByName("Azure-Shield of Coldarra",17) PickupContainerItem(4,1) PickupInventoryItem(16) end

It's less elegant, but it works. Once again, make sure you have the item not currently being used in the first slot of the left-most bag.

[Kyng]

Source: Mozman I really like this for cc'd mobs: Tab sunder - seamlessly tab to the nearest target, sunder them and switch back to your current target – you won't even see the switch but they'll be sundered... /targetenemy /cast Sunder Armor /targetlasttarget edit: actually updated the explanation to include the crowd control info

I've been testing this on some melee mobs over in Nagrand. I shall try to explain what I've been experiencing. I would take two mobs and mark them, one as the skull and one as the moon. The skull in our guild means the primary focus fire mob. A moon would be simply tanked by the main tanked so it doesn't go eat the healer's face.

I would charge the skull, and put 2 sunder's on the skull. I would then swap to defensive and push bloodrage. From here, if I push the above macro, it makes my target the MOON, and then sunder's the original skull. If I continue to push the macro, the skull is what gets sundered, leaving me to manually cause threat against the moon. This seems to be backwards of what other people say this macro does. Then even with putting the sunder's on the skull, when I go to cause threat on the moon manually, when I go back to push this macro again after a pause, THEN it puts my target back on the skull and sunder's the moon.

Is there a way to make it so I keep my target on the skull, and when pushing it, it will sunder the moon and then put me back on the skull?

Any help would be appreciated.

[Mozman]

@ Kyng

"Is there a way to make it so I keep my target on the skull, and when pushing it, it will sunder the moon and then put me back on the skull?"

that is exactly how it works? I've not tested it for a loong time tho?

what it does is it 'tabs' to the other target, sunders them and then retargets..

try this - get 2 mobs, put demo shout on both, don't put any sunders on either, in fact only do white damage on one of them. now use the macro, use it again and again. Now actually manually target the 'other' mob i.e. the one that you've not been hitting and check the sunders... there should be no sunders on the one you've been hitting as the original target

I'm at work - pls let me know how that goes

[Kyng]

I understand that's how it works for some people, but it doesn't for me.

I just went out to Nagrand again to give it a try. I put demo on both, and while targeting the primary mob, I pushed it the first time, and it didn't target either of them...

I pushed it again and it went back to the skull/primary mob. Then another push and it finally put a sunder on the one beside it. Then it would just alternate, sometimes it would work as it's supposed to, sometimes it would target the moon and then stay as the moon and not sunder at all.

I've copied the macro exactly, several times. Two other guild warriors says it works fine for them, two others like myself say it does similar.

[Kyng]

In fact, I just did another test and the first time I clicked it, it targeted myself.

[Mozman]

if it targeted you ? maybe you were the 'last target' ? strange

hmmm kk I'll have a look (much) later in game myself..

in any event, whilst I used it a bit I prefer using the mouseover sunder macro as there is no risk then of breaking a cc'd mob and it will come for you after it breaks rather than the cc'er.

for multi tanking I generally manually target if cc is near between the ones I'm tanking so I know exactly what I'm doing to each, tho I much prefer to have the mobs away from cc and use the ''multi tanking masher' with sunder, cleave and thunderclap alternating between them - its actually very good

[oorgle]

Source: arbster Hi there - sorry my original suggestion didn't work - I wrote it off the top of my head without access to WoW. I think it fails due to trying to move the same item twice, which seems to confuse LUA sometimes. However, this version does work: /run if IsEquippedItemType("Shields") then EquipItemByName("Vindicator's Brand",16) PickupContainerItem(4,1) PickupInventoryItem(17) else EquipItemByName("Azure-Shield of Coldarra",17) PickupContainerItem(4,1) PickupInventoryItem(16) end It's less elegant, but it works. Once again, make sure you have the item not currently being used in the first slot of the left-most bag.

Hi again,

I'm back again with fury macro swapping problems. I finally got around to upgrading my mainhand (from Vindicator's Brand to Fool's Bane), but now the macro malfunctions. I've replaced the text "Vindicator's Brand" with "Fool's Bane", but the macro loses functionality and I have to relog to be able to move anything around in my inventory anymore.

Seems to me that should be the only thing I need to change to update the mainhand dual wield weapon, so why is it not working?

edit: Well, it works halfway -- it'll swap to FG/shield from FB/FG, but it won't swap back. why?

edit again: it works fine with another mace, the vendor-bought "Ancient Bone Mace", so it can't be maces in general. is it just some quirk with the Fool's Bane that it doesn't work with a macro like this for some reason?

[arbster]

Source: oorgle edit again: it works fine with another mace, the vendor-bought "Ancient Bone Mace", so it can't be maces in general. is it just some quirk with the Fool's Bane that it doesn't work with a macro like this for some reason?

Strange behaviour - the only thing I can think is that it's something to do with the quote in the item name. Did you try shift-clicking on the item to make doubly sure that you got the correct name in your macro?

[Mozman]

as a heads up, Oorgle posted this in the wow forums macro sticky:

for anybody interested or stuck with a similar problem I have been having, I solved the problem. I think the issue had to do with the fact that the Fool's Bane is mainhand only, and for some reason the macro was doing something that made it think it had to be in the offhand, and it locked up. I switched the order of operations in the first half of the if-then, and it works fine now.

old macro: (doesn't work with a main hand only weapon in the main hand)

/run if IsEquippedItemType("Shields") then EquipItemByName("Vindicator's Brand",16) PickupContainerItem(4,1) PickupInventoryItem(17) else EquipItemByName("Azure-Shield of Coldarra",17) PickupContainerItem(4,1) PickupInventoryItem(16) end

new macro: (works with a main hand weapon)

/run if IsEquippedItemType("Shields") then EquipItemByName("Vindicator's Brand",16) PickupInventoryItem(17) PickupContainerItem(4,1) else EquipItemByName("Azure-Shield of Coldarra",17) PickupContainerItem(4,1) PickupInventoryItem(16) end

now instead of picking up the container slot containing the fireguard (after it's been swapped out for the mainhand) first, it picks up the shield in your offhand first and swaps it that way.

[arbster]

@ Moz: Thanks for keeping me in the loop - I don't check the other forum that much as I'm not permitted to log on and reply.

@ oorgle: Good work on fixing the problem, and your conclusion about Fool's Bane being Mainhand-only can be the only answer, but I really don't understand what might have been happening in the original macro to make it think it wanted to go in the MH. Must be some quirk of WoW LUA implementation, or something. I'll be picking up the inventory items first in future though - thanks for the insight.

[Mozman]

updated for 2.2

[Trû]

This is just a small list of links for those who might want to go into more depth or just want a quick access to more complete information.

WoW API as of 2.1
2.2 Changes!
Slash Commands - I'm not sure how recently updated this is, but it's fairly complete for all that...

I might ( ) get around to writing a simple debugging guide later, to help people figure out why their macros/scripts aren't working, or seem to work oddly in certain situations.


AND...
A big hug to Mozman for all his ongoing effort and expertise in putting this out here for us, and his willingness in keeping it going.

[SomeRandomTwink]

As of 2.0.1, I use a diffirent macro for Weapon Swaping

/equip <insert 2h weapon here>
/equip <insert 1h weapon here>
/equip <insert 1h weapon or sheild here>

What is does is switch from your 2H to your tank weaps or DW weps

PS: dont insert the <> signs

[Gajanana]

am I doing something wrong? I can't get the macros to work. I'm trying the following:

Mocking Blow - swaps you to Battle stance and then casts Mocking Blow, then switches you back to Defensive Stance.

#show Mocking Blow
/cast [nostance:1] Battle Stance; Mocking Blow
/cast [nostance:2]Defensive Stance

On this one it puts me into Battle Stance but does not do the mocking blow or put me back into defensive stance.

Fear Dance - think Nightbane, Onyxia... will put you into zerker stance, pop zerker rage and then (back) to def stance if you have a shield on or to battle if not

#showtooltip Berserker Rage
/cast [stance:3] Berserker Rage; Berserker Stance
/cast [noequipped:shields] Battle Stance; Defensive Stance

Just switches me to Berserker stance.....nothing else.

[Mozman]

@ random - nice

@ Gajanana - use it 3 times - once for the stance swap, again for the ability and one more to switchback

[Sarl]

K First I am new to macro's and Love all the material you guys provide for us I get lost for hours here it seems lol.
Second is it possible to have a sequence cast Block,revenge,slam,sunder?

[Gajanana]

Source: Mozman @ random - nice @ Gajanana - use it 3 times - once for the stance swap, again for the ability and one more to switchback

Ok, I feel like a total n00b now, lol. Thanks man, that did the trick

[Lavache]

Source: Mozman Shield Slam with Gnomeregan Auto-Blocker 600 - this allows you to Shield Slam at the exact same time as trinket activation. It checks to make sure your target is alive and hostile, and will also not activate the trinkets if you do not have a Shield already equipped. If you do not, it will equip the Shield, so you can simply double-click it. #show Gnomeregan Auto-Blocker 600 /use [harm,nodead,equipped:Shields] 13 /stopcasting /cast [equipped:Shields] Shield Slam /equip [noequipped:Shields] Azure-Shield of Coldarra This is important because it allows 4 Shield Slams reliably off one trinket use. Since you will use the SS at the 0 second marker, then at the 6, 12, and 18 second marker, with regular server lag you can still get 4 in safely.

is it possible to set this up so it will cast shield slam even if i dont have the autoblocker on? i would love to get this down to a one button thing instead of the current 2 (huge difference i know ) if not i can certainly live with it either way.

also - do i just spam this button, or go back to my normal ss rotation with a seperate button? i know with my hunter i have a kill command macro that i just mash constantly instead of hitting lots of other things.

[Kazeyonoma]

this will work even if you don't have autoblocker on, it just will always show up as greyed out.

What i did was changed the #show to #Show Shield Slam

the /use 13 will just use whatever is in your trinket slot #13, if there is no use effect, it wil work exactly like shield slam.

and yes after you pop it, you can just hit your usual shield slam rotation buttons, or just put this in place of your shield slam button.